[BusyBox 0001130]: arp applet

[bugs at busybox.net]

A NOTE has been added to this issue. 
====================================================================== 
http://busybox.net/bugs/view.php?id=1130 
====================================================================== 
Reported By:                espakman
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   1130
Category:                   New Features
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     assigned
====================================================================== 
Date Submitted:             12-23-2006 12:35 PST
Last Modified:              12-24-2006 10:42 PST
====================================================================== 
Summary:                    arp applet
Description: 
Busybox currently doesn't contain an arp applet. Someone wrote an arp
applet a long time ago. I rediffed this version against bb 1.3.0 and it
applies cleanly against current SVN.
====================================================================== 

---------------------------------------------------------------------- 
 vda - 12-23-06 23:44  
---------------------------------------------------------------------- 
Unused #define:

+
+#define APPLET_NAME "arp"
+

Inconsistent style: 3-space indent AND 4-space indent in the same file:

+    (void) fclose(fp);
+
+    return 0;
+}
+
+int arp_main(int argc, char **argv)
+{
+   int what, i;
+
+   /* Initialize variables... */
+   if ((hw = get_hwtype(DFLT_HW)) == NULL) {
+      bb_error_msg("%s: hardware type not supported!\n", DFLT_HW);
+      return -1;
+   }

Please reformat to bbox style (indents by 1 tab).

 

---------------------------------------------------------------------- 
 espakman - 12-24-06 09:07  
---------------------------------------------------------------------- 
Second try, new patch attached. 

---------------------------------------------------------------------- 
 espakman - 12-24-06 10:42  
---------------------------------------------------------------------- 
Now run through indent, to be fully bbox style complient. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
12-23-06 12:35  espakman       New Issue                                    
12-23-06 12:35  espakman       Status                   new => assigned     
12-23-06 12:35  espakman       Assigned To               => BusyBox         
12-23-06 12:35  espakman       File Added: busybox-arp.patch                    
12-23-06 23:44  vda            Note Added: 0001931                          
12-23-06 23:44  vda            Note Edited: 0001931                         
12-24-06 09:06  espakman       File Added: busybox-arp2.patch                   

12-24-06 09:07  espakman       Note Added: 0001932                          
12-24-06 10:41  espakman       File Added: busybox-arp3.patch                   

12-24-06 10:42  espakman       Note Added: 0001933                          
======================================================================