svn commit: trunk/busybox/loginutils

[vda at busybox.net]

Author: vda
Date: 2006-10-31 10:30:56 -0800 (Tue, 31 Oct 2006)
New Revision: 16478

Log:
login: add big fat comment about SIGINT - prevent
adding/deleting that code again and again


Modified:
   trunk/busybox/loginutils/login.c


Changeset:
Modified: trunk/busybox/loginutils/login.c
===================================================================
--- trunk/busybox/loginutils/login.c	2006-10-31 17:34:44 UTC (rev 16477)
+++ trunk/busybox/loginutils/login.c	2006-10-31 18:30:56 UTC (rev 16478)
@@ -386,7 +386,14 @@
 	// /* TIOCSCTTY: steal tty from other process group */
 	// if (ioctl(0, TIOCSCTTY, 1)) error_msg...
 
-	signal(SIGALRM, SIG_DFL); /* set signals to defaults */
+	/* set signals to defaults */
+	signal(SIGALRM, SIG_DFL);
+	/* Is this correct? This way user can ctrl-c out of /etc/profile,
+	 * potentially creating security breach (tested with bash 3.0).
+	 * But without this, bash 3.0 will not enable ctrl-c either.
+	 * Maybe bash is buggy?
+	 * Need to find out what standards say about /bin/login -
+	 * should it leave SIGINT etc enabled or disabled? */
 	signal(SIGINT, SIG_DFL);
 
 	run_shell(tmp, 1, 0, 0);	/* exec the shell finally */