[BusyBox 0001317]: ether-wake will send broadcasts if not told so

[bugs at busybox.net]

The following issue has been CLOSED 
====================================================================== 
http://busybox.net/bugs/view.php?id=1317 
====================================================================== 
Reported By:                firetwister
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   1317
Category:                   Networking Support
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     closed
Resolution:                 open
Fixed in Version:           
====================================================================== 
Date Submitted:             04-16-2007 14:57 PDT
Last Modified:              04-16-2007 16:16 PDT
====================================================================== 
Summary:                    ether-wake will send broadcasts if not told so
Description: 
ether-wake will send broadcasts if any flag is specified. It should only
send broadcasts if -b is supplied.

At line 125 the flags get parsed

flags = getopt32(argc, argv, "bi:p:", &ifname, &pass);

At line 141 the return value of getopt32 will get assigned to 'get_fill',
which will set the broadcast address if flags != 0.

pktsize = get_fill(outpack, &eaddr, flags /*& 1 [OPT_BROADCAST]*/);

Simply move the '/*' 3 characters to the right and it works ;-)

This bug seems to be very old, at least the oldest and the latest version
in svn are affected.
====================================================================== 

---------------------------------------------------------------------- 
 vda - 04-16-07 16:16  
---------------------------------------------------------------------- 
Fixed in rev 18463, thanks! 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
04-16-07 14:57  firetwister    New Issue                                    
04-16-07 14:57  firetwister    Status                   new => assigned     
04-16-07 14:57  firetwister    Assigned To               => BusyBox         
04-16-07 16:16  vda            Status                   assigned => closed  
04-16-07 16:16  vda            Note Added: 0002323                          
======================================================================