[BusyBox 0001496]: tftp applet never reaches timeout retry limit

[bugs at busybox.net]

The following issue has been SUBMITTED. 
====================================================================== 
http://busybox.net/bugs/view.php?id=1496 
====================================================================== 
Reported By:                whitpa
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   1496
Category:                   Other
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     assigned
====================================================================== 
Date Submitted:             09-10-2007 06:04 PDT
Last Modified:              09-10-2007 06:04 PDT
====================================================================== 
Summary:                    tftp applet never reaches timeout retry limit
Description: 
The "timeout" variable never gets a chance to get any smaller than
TFTP_NUM_RETRIES-1, because it gets reset to TFTP_NUM_RETRIES on every
loop iteration.

I'm guessing that networking/tftp.c:221, which reads:

                timeout = TFTP_NUM_RETRIES;     /* re-initialize */

... ought to be somewhere *above* the "send_again" label!

Not sure when this broke, exactly, but it's at least Busybox 1.6.0
onwards.
====================================================================== 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
09-10-07 06:04  whitpa         New Issue                                    
09-10-07 06:04  whitpa         Status                   new => assigned     
09-10-07 06:04  whitpa         Assigned To               => BusyBox         
======================================================================