[BusyBox] further ash size reduction

Aaron Lehmann aaronl at vitelus.com
Fri Aug 10 03:32:06 UTC 2001


On Fri, Aug 10, 2001 at 01:26:24PM +0400, Vladimir N. Oleynik wrote:
> > That can be fun. For your implementation I tried changing basesyntax,
> > dqsyntax, etc from tables with 4 of the 8 bits of each entry wasted
> > into a 64-bit int with 4 bits for every index. It backfired, partially
> > because a lot of shifting and masking is needed since those tables are
> > used in many place and also in part because i386 can't natively handle
> > such big integers.
> 
> Here there are enough 16 bits.

Excuse me?

> > I was thinking of this exact optimization when I first read his patch.
> > 
> > I also like your basesyntax_dqsyntax_sqsyntax_arisyntax #defines more
> > than vlad's use of raw numbers. It should be easy for him to fix that,
> > though.
> 
> And at me opposite opinion. Can I enough comments in the source text am simple
> has 
> not added? There transparent indexes, all intercouplings very simply are traced
> and 
> vary literally in one place. 

I thought it was nice how Manuel's patch #define the numbers to names
that made them descriptive so you could know what they meant for each
syntax context without scrolling up to some other table somewhere;





More information about the busybox mailing list