[BusyBox] Question to httpd

[Vladimir N. Oleynik]

Steven,

> >>correct me if I am wrong, but /etc/httpd.conf (i.e. the config file) is only
> >>used for "ip address filtering and basic authentication" when
> >>CONFIG_FEATURE_HTTPD_BASIC_AUTH is defined.
> >
> > No.
> > IP checking as checkperm(NULL, config->rmt_ip)
> 
> Well Config.in says
> 
> config CONFIG_FEATURE_HTTPD_BASIC_AUTH
>          bool "  Enable Basic Authentication and IP address checking"
>            Utilizes /etc/httpd.conf for security settings allowing
>            ip address filtering and basic authentication on a per url basis.

Oops. This typo (and not me).
 
> And in httpd.c it looks as if /etc/httpd.conf only contains security stuff.
> That's why I thought I don't need a /etc/httpd.conf when I don't enable
> CONFIG_FEATURE_HTTPD_BASIC_AUTH...
> 
> You see?

Don`t.
 
 > ------------------------------------------------------------------------
> > @@ -1519,7 +1521,6 @@
> >       if(length < 0)          // closed
> >               length = 0;
> >       body[length] = 0;       // always null terminate for safety
> > -     urlArgs = body;
> >        }
> >      }
> 
> What happens if I don't correct this?

URL?args can`t overwrite always. This original author bug, I found
after strong testing from my project.


--w
vodz
-------------- next part --------------
diff -rbu busybox.orig/AUTHORS busybox/AUTHORS
--- busybox.orig/AUTHORS	Mon Feb 10 19:35:04 2003
+++ busybox/AUTHORS	Mon Feb 10 19:37:17 2003
@@ -71,7 +71,7 @@
 
 Vladimir Oleynik <dzo at simtreas.ru>
     cmdedit; xargs(current), httpd(current);
-    ports: ash, crond, fdisk, inetd, stty, traceroute, telnetd, top;
+    ports: ash, crond, fdisk, inetd, stty, traceroute, top;
     locale, various fixes
     and irreconcilable critic of everything not perfect.
 
diff -rbu busybox.orig/docs/busybox_footer.pod busybox/docs/busybox_footer.pod
--- busybox.orig/docs/busybox_footer.pod	Mon Feb 10 19:35:34 2003
+++ busybox/docs/busybox_footer.pod	Mon Feb 10 19:36:54 2003
@@ -114,7 +114,7 @@
 Vladimir Oleynik <dzo at simtreas.ru>
 
     cmdedit, xargs(current), httpd(current);
-    ports: ash, crond, fdisk, inetd, stty, traceroute, telnetd, top;
+    ports: ash, crond, fdisk, inetd, stty, traceroute, top;
     locale, various fixes
     and irreconcilable critic of everything not perfect.
 
diff -rbu busybox.orig/networking/Config.h busybox/networking/Config.h
--- busybox.orig/networking/Config.h	Mon Feb 10 19:34:30 2003
+++ busybox/networking/Config.h	Mon Feb 10 19:38:25 2003
@@ -51,12 +51,12 @@
 	  internet superserver daemon for usaging.
 
 config CONFIG_FEATURE_HTTPD_BASIC_AUTH
-	bool "  Enable Basic Authentication and IP address checking"
+	bool "  Enable Basic Authentication"
 	default n
 	depends on CONFIG_HTTPD
 	help
-	  Utilizes /etc/httpd.conf for security settings allowing 
-          ip address filtering and basic authentication on a per url basis.
+	  Utilizes /etc/httpd.conf for basic authentication
+	  on a per url basis.
 
 config CONFIG_FEATURE_HTTPD_CGI
 	bool "  Enable support Common Gateway Interface"