[BusyBox] [PATCH] kill error message

[Jason Schoon]

I was a bit confused myself. Under glibc on my platform at least, I got the 
following message from ash when deleting a non-existent task:

~ # kill 394
kill: 2: No such process

Do we need special handling for the %m formatter, or should it be eradicated 
in the name of least-common denominator? More details about standard 
libraries being used and platform would be useful here.

Also, I thought ash was mostly a direct port of dash, so wouldn't this issue 
apply upline as well?

On 8/15/05, Tito <farmatito at tiscali.it> wrote:
> 
> On Monday 15 August 2005 09:27, Vladimir N. Oleynik wrote:
> > Rob,
> >
> > >> The attached patch fixes the error message when trying to kill a
> > >> non-existing pid in ash
> > >>
> > >> BEFORE
> > >> # kill 1234
> > >> kill: 1: m
> >
> >
> > I do not know, you use what libc, but the busybox project in many places
> > uses "%m" opportunity.
> Hi,
> yes we often used this, so we have to decide if it
> is legal or not..........
> 
> This is just a simple search, so there may be some false positives.
> 
> file:/root/busybox/e2fsprogs/tune2fs.c
> file:/root/busybox/editors/awk.c
> file:/root/busybox/init/init.c
> file:/root/busybox/libbb/login.c
> file:/root/busybox/libbb/messages.c
> file:/root/busybox/loginutils/getty.c
> file:/root/busybox/miscutils/crond.c
> file:/root/busybox/miscutils/devfsd.c
> file:/root/busybox/miscutils/rx.c
> file:/root/busybox/miscutils/time.c
> file:/root/busybox/networking/httpd.c
> file:/root/busybox/networking/ifupdown.c
> file:/root/busybox/networking/inetd.c
> file:/root/busybox/networking/nameif.c
> file:/root/busybox/networking/udhcp/arpping.c
> file:/root/busybox/networking/udhcp/ChangeLog
> file:/root/busybox/networking/udhcp/clientpacket.c
> file:/root/busybox/networking/udhcp/clientsocket.c
> file:/root/busybox/networking/udhcp/dhcpc.c
> file:/root/busybox/networking/udhcp/dhcpd.c
> file:/root/busybox/networking/udhcp/packet.c
> file:/root/busybox/networking/udhcp/pidfile.c
> file:/root/busybox/networking/udhcp/script.c
> file:/root/busybox/networking/udhcp/signalpipe.c
> file:/root/busybox/networking/udhcp/socket.c
> file:/root/busybox/procps/top.c
> file:/root/busybox/scripts/mkdep.c
> file:/root/busybox/shell/ash.c
> file:/root/busybox/shell/hush.c
> file:/root/busybox/shell/lash.c
> file:/root/busybox/sysklogd/klogd.c
> 
> Ciao,
> Tito
> > >> AFTER
> > >> # kill 1234
> > >> kill: 3: kill 1234: No such process
> >
> >
> > Really to like you here this result?
> >
> > > Applied to both 1.1 and -stable.
> >
> >
> > Return back as was!
> >
> >
> > --w
> > vodz
> >
> 
> 
> _______________________________________________
> busybox mailing list
> busybox at mail.busybox.net
> http://busybox.net/mailman/listinfo/busybox
> 
> 
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://busybox.net/lists/busybox/attachments/20050815/77e61acd/attachment.htm