[BusyBox] [patch] remove duplicate rule in toplevel Makefile

Bernhard Fischer rep.nop at aon.at
Tue Aug 23 21:29:11 UTC 2005


Hi,

- remove duplicate rule in toplevel Makefile
- peruse make's builtin notion of `dirname $@'

Please apply.
-------------- next part --------------
diff -u busybox.out/Makefile busybox/Makefile
--- busybox.out/Makefile	2005-08-23 23:19:07.000000000 +0200
+++ busybox/Makefile	2005-08-23 23:17:05.000000000 +0200
@@ -115,7 +115,7 @@
 all_tree:	$(ALL_MAKEFILES)
 
 $(ALL_MAKEFILES): %/Makefile: $(top_srcdir)/%/Makefile
-	d=`dirname $@`; [ -d "$$d" ] || mkdir -p "$$d"; cp $< $@
+	[ -d $(@D) ] || mkdir -p $(@D); cp $< $@
 
 # In this section, we need .config
 -include $(top_builddir)/.config.cmd
@@ -234,9 +234,6 @@
 # configuration
 # ---------------------------------------------------------------------------
 
-$(ALL_MAKEFILES): %/Makefile: $(top_srcdir)/%/Makefile
-	d=`dirname $@`; [ -d "$$d" ] || mkdir -p "$$d"; cp $< $@
-
 scripts/config/conf: scripts/config/Makefile $(top_srcdir)/Rules.mak
 	$(MAKE) -C scripts/config conf
 	- at if [ ! -f .config ] ; then \


More information about the busybox mailing list