[BusyBox] Re: ifconfig: Clean up. [PATCH]

[Glenn L. McGrath]

On Sun, 24 Jul 2005 20:50:39 -0500
Rob Landley <rob at landley.net> wrote:

> The problem is I really hate adding extra #ifdefs, especially for
> something  that small.  For 1.0.1 this doesn't really need to be
> addressed at all, and  for 1.1 what would be really nice would be a
> general reorganization where we  have libbb.h have one #ifdef that set
> "do_cleanup" to 0 or 1, and then we  used if(do_cleanup) in the body
> of the code and let the compiler's dead code  elimination yank it for
> us...
> 
> Opinions?

Is it just a question of aesthetics ?

People will forever agrue about which style looks nicest, its just what
people are used to i think.

Best we can do is try and adhere to common practices (if there is one)
and be consistent through all our code, at least we can might get used
to it that way.



Glenn