[BusyBox] Re: hexdump -C [PATCH]

[Shaun Jackman]

My mistake. It actually *adds* 80 bytes to the code size. I had it
backwards. Here are the numbers:

*Before*
$ size libbb/dump.o util-linux/hexdump.o busybox
   text    data     bss     dec     hex filename
   4277      12      40    4329    10e9 libbb/dump.o
    665       0       0     665     299 util-linux/hexdump.o
  244055    2312   36800  283167   4521f busybox

*After*
$ size libbb/dump.o util-linux/hexdump.o busybox
   text    data     bss     dec     hex filename
   4265      12      40    4317    10dd libbb/dump.o
    772       0       0     772     304 util-linux/hexdump.o
  244135    2312   36800  283247   4526f busybox

The bug fix does reduce the code size of bpad as the ChangeLog entry
reads, but the new feature does add to the code size of hexdump by
about 100 bytes. Does this warrant a CONFIG_FEATURE_xxx option?

Cheers,
Shaun

On 7/19/05, Shaun Jackman <sjackman at gmail.com> wrote:
> This patch adds the -C feature to hexdump and fixes a bug in dump.c
> (bpad) that affects the -C switch. It also reduces overall code size
> by 80 bytes on my system because it recodes bpad to use library
> functions.
> 
> Cheers,
> Shaun