[BusyBox] SVN revision 10880 is a dup of 10407
Paul Fox
pgf at brightstareng.com
Thu Jul 21 20:19:23 UTC 2005
> To the powers that be (i.e. those with SVN commit privileges)
>
> Revision 10880 applies a duplicate patch to networking/udhcp/dhcpc.c.
sigh. thanks. there's a classic case of a) patch gone bad (not
quite enough context in the diff i applied), b) process failure --
you couldn't update the bug system, and the committer didn't,
and/or c) my carelessness in applying it, not noticing either the
adjacent code or the adjacent log message. take your pick. :-)
i'll revert it.
paul
>
>
> --- /trunk/busybox/networking/udhcp/dhcpc.c 2005/07/20 19:07:27
> 10879
> +++ trunk/busybox/networking/udhcp/dhcpc.c 2005/07/20 19:13:21
> 10880
> @@ -443,6 +443,11 @@
> if (memcmp(client_config.arp,packet.chaddr,6))
> continue;
>
> + if (memcmp(packet.chaddr, client_config.arp, 6)) {
> + DEBUG(LOG_INFO, "packet does not have
> our chaddr -- ignoring");
> + continue;
> + }
> +
> if ((message = get_option(&packet,
> DHCP_MESSAGE_TYPE)) == NULL) {
> DEBUG(LOG_ERR, "couldnt get option from
> packet -- ignoring");
> continue;
>
>
> For the record, I think this situation resulted because I (am not
> able)/(am too stupid to figure out how) to flag as resolved an issue
> that I raised in the bug tracker.
>
> Cheers
> Keith
> _______________________________________________
> busybox mailing list
> busybox at mail.busybox.net
> http://busybox.net/mailman/listinfo/busybox
=---------------------
paul fox, pgf at brightstareng.com
More information about the busybox
mailing list