[BusyBox] Re: ifconfig: Clean up. [PATCH]

Tito farmatito at tiscali.it
Mon Jul 25 20:37:44 UTC 2005


On Monday 25 July 2005 19:18, Shaun Jackman wrote:
> On 7/25/05, Tito <farmatito at tiscali.it> wrote:
> > Please use brackets on all if and else statements, even if it is only one
> > line. Example:
> ...
> 
> If either foo or stmt1 are simple, I much prefer...
> 	if (foo) stmt1;
> If both foo and stmt1 are complex, I prefer...
> 	if (foo)
> 		stmt1;
> I almost never prefer...
> 	if (foo) {
> 		stmt1;
> 	}
> 
> I don't find the extra punctuation adds to the readability of the
> code. I don't like extra parenthesis around the argument to the
> keywords return and sizeof for the same reason.
> 	return n;
> not
> 	return (n);
> and
> 	sizeof buf
> not
> 	sizeof (buf)
> 
> Cheers,
> Shaun
> 
> 
Hi,
So it would be best to remove /docs/style-guide.txt ;-)

Ciao,
Tito



More information about the busybox mailing list