[BusyBox] Re: ifconfig: Clean up. [PATCH]
Rainer Weikusat
rainer.weikusat at sncag.com
Tue Jul 26 10:25:49 UTC 2005
Shaun Jackman <sjackman at gmail.com> writes:
> On 7/25/05, Rob Landley <rob at landley.net> wrote:
>> > I'd to spell do_cleanup as DO_CLEANUP. If I saw...
>> > if (DO_CLEANUP)
>> > ... I'd understand it was a conditional compilation. If I saw...
>> > if (do_cleanup)
>>
>> I was actually thinking of a static const int.
>
> Getting back to the original thread of conversation, here's an
> implementation of my previous idea. I rather like the consistency this
> method offers.
[...]
> +#ifndef CONFIG_FEATURE_CLEAN_UP
> +static const int CONFIG_FEATURE_CLEAN_UP = 0;
> +#endif
[...]
> + if (CONFIG_FEATURE_CLEAN_UP) close(sockfd);
> return goterr;
> }
What is this supposed to accomplish, besides inflating the binary for
no reason?
More information about the busybox
mailing list