[BusyBox] Re: newlib's libbb/printf.c [PATCH]

[Mike Frysinger]

On Wednesday 27 July 2005 03:07 am, Rob Landley wrote:
> On Tuesday 26 July 2005 18:05, Mike Frysinger wrote:
> > On Monday 25 July 2005 02:33 pm, Shaun Jackman wrote:
> > > > 2005-04-05  Shaun Jackman  <sjackman at gmail.com>
> > > >
> > > >         * libbb/printf.c: Check for __NEWLIB_H__ before __GLIBC__.
> >
> > added, thanks
> > -mike
>
> A) I don't suppose there's an easy way to centralize all the libc
> dependencies into a compiler.h header file, somewhere?

maybe ... that would make life easier

> B) If newlib is lying and claiming to be glibc, yet doesn't work like glibc
> for something that we care about, why isn't it newlib that's broken?

you could say the same exact thing for uclibc

> C) Half this patch is whitespace noise adding spaces between the # and the
> preprocessor directive (which I personally consider a regression, and would
> have applied a patch to _undo_.  But that's just me...)

yes, i added some whitespace changes that Shaun did not include ... they 
brought the file in sync with the rest of the whitespacing usage

clearly you and i disagree on this point ... i find indented preprocessor 
macros to greatly improve readability ... i do agree it should have been a 
sep commit though
-mike