[BusyBox] pre-commit feedback, please

[Paul Fox]

okay, now that the dust has settled a little (and rob has stopped
yelling at me ;-) after my commits for the easy things that might
be considered for 1.0.1, i'd like to start committing things
from the bug system that would be in 1.1.  as before, so far i'm
only considering bug reports that have clean patches associated
with them.

i'm not comfortable doing this without some prior consensus:
a) just because something's been in the bug system for a long
time doesn't mean anyone but the original submitter has given it
any thought, or any testing (witness loop.c :-), b) while many of
these have been discussed on the list, many have not, and c) some
are my patches, and i'm probably not objective.

so, to that end, i'd really like to get some feedback on the
following.  there are more than this -- these are just the ones
i've kind of looked at, and that i'd like to hear about now. 
please consider both the report itself, _and_ the patch that's
supposed to fix it.  even if the patch is wrong, knowing that the
intent is good is useful.  feedback either here on the list, or
as notes in the bug system is good.  (if you use notes, i'd
appreciate a private email so i know to go look.)

thanks...
paul


0000003 03-16-05 [PATCH] Do not export all make variables
    [ submitter pkj was going to commit this.  see also bug #94 ]

0000004 03-16-05 patch for httpd to support PHP CGI mode
    [ questionable PHP-specific CGI variable.  see http://bugs.php.net/bug.php?id=28227 ]

0000008 03-16-05 modprobe applet is dependent on having a shell
    [ patch and new code are big enough that i think this should
       be configurable ]

0000024 03-16-05 patch: allow init to set controlling tty
    [ my bug/patch -- the need for this has come up a few times
       on the list in the last year, but no one has ever said yea or
       nay on this feature.  ]

0000025 03-24-05 vi-editing mode for ash
    [ my bug/patch -- i may be the only person who wants this,
	but if there's anyone else like me, it'll make them _really_
	happy. ;-) ]

0000028 03-16-05 patch: new setsid applet
    [ my bug/patch -- i hope this is non-controversial ]

0000037 03-16-05 patch: allow suppression of default client-id
    [ my bug/patch -- makes udhcpc more compatibile with both
       u-boot and the linux kernel ]

0000046 03-16-05 Config Applet
    [ new applet -- displays busybox config options.  i'm not sure i
	understand why this is needed.  ]

0000071 03-16-05 patch: implement "--color" option for ls coloring control
    [ my bug/patch -- this has been hashed over on the list.  can i commit? ]

0000072 03-16-05 Add applet to redirect console output via ioctl(..., TIOCCONS)
    [ looks okay to me ]

0000073 03-16-05 Add option to inetd applet to run in foreground
    [ looks okay to me -- option already present on uclinux ]

0000094 03-16-05 Busybox 'make install' does not respect PREFIX when using O=
    [ see also bug #3 -- if everything's exported, why is this needed? ]

0000115 03-25-05 ifenslave
    [ new applet ]

0000132 03-16-05 Implement fork using longjmp
    [ somewhat controversial, i recall... ]


=---------------------
 paul fox, pgf at brightstareng.com