[1.1.2] missing build deps for mount

[Bernhard Fischer]

On Wed, Apr 12, 2006 at 02:21:36AM -0700, Andre wrote:
>--- Bernhard Fischer <rep.nop at aon.at> wrote:
>> On Tue, Apr 11, 2006 at 04:31:12PM -0700, Andre wrote:
>> >I get the following while trying to build 1.1.2 (and 1.1.1)
>> 
>> >  LINK busybox_unstripped
>> >/home/andre/busybox-1.1.2/util-linux/util-linux.a(mount.o): In
>> >function `singlemount':
>> >mount.c:(.text+0x420): undefined reference to `del_loop'
>> >collect2: ld returned 1 exit status
>> >
>> 
>> >CONFIG_MOUNT=y
>> >CONFIG_UMOUNT=y
>> 
>> what's your gcc -v and version of binutils?
>> 
>
>$ arm-linux-uclibc-gcc -v
>Reading specs from
>/usr/local/arm/3.4.4-uclibc/lib/gcc/arm-linux-uclibc/3.4.4/specs
>Configured with:
>/home/andre/buildroot/toolchain_build_arm/gcc-3.4.4/configure
>--prefix=/usr/local/arm/3.4.4-uclibc --build=i386-pc-linux-gnu
>--host=i386-pc-linux-gnu --target=arm-linux-uclibc
>--enable-languages=c --enable-shared --disable-__cxa_atexit
>--enable-target-optspace --with-gnu-ld --disable-nls --enable-threads
>--enable-multilib
>Thread model: posix
>gcc version 3.4.4
>
>$ arm-linux-uclibc-as -version
>GNU assembler 2.16.1
>...
>
>> 
>> You don't seem to have CONFIG_FEATURE_MOUNT_LOOP nor CONFIG_LOSETUP
>> set, so loopFile should be 0, thus the compiler should have
>> optimized away the call to del_loop()..
>> 
>
>I tried again with a gcc-4.0.2 based uclibc toolchain and that
>compiles and links without problems.
>
>
>> Index: util-linux/mount.c
>> ===================================================================
>> --- util-linux/mount.c  (revision 14831)
>> +++ util-linux/mount.c  (working copy)
>> @@ -351,7 +351,7 @@
>>  
>>         // If mount failed, clean up loop file (if any).
>>  
>> -       if (rc && loopFile) {
>> +       if (ENABLE_FEATURE_MOUNT_LOOP && rc && loopFile) {
>>                 del_loop(mp->mnt_fsname);
>>                 if (ENABLE_FEATURE_CLEAN_UP) {
>>                         free(loopFile);
>> 
>> 
>
>This fixes the problem with gcc-3.4.4 

Thanks for checking.

I'll leave this to landley or somebody else..