[PATCH] passwd more size reduction.

[Tito]

On Friday 01 December 2006 00:21, Denis Vlasenko wrote:
> On Thursday 30 November 2006 22:15, Tito wrote:
> > Hi,
> > this patchreduces size of passwd.
> > Bloatmeter says:
> > function                                             old     new   delta
> > passwd_main                                         1771    1779      +8
> > .rodata                                           134358  134102    -256
> > ------------------------------------------------------------------------------
> > (add/remove: 0/0 grow/shrink: 1/1 up/down: 8/-256)           Total: -248 bytes
> > 
> > but it seems not taking into account the removal of
> > the static void set_filesize_limit(int blocks)
> > function.
> 
> Too late. ;) I just cut it down by 500 bytes.
> 
> # size passwd.o
>    text    data     bss     dec     hex filename
>    2805       0       0    2805     af5 passwd.o
> 
> bbox 1.2.1:
>  size passwd.o
>    text    data     bss     dec     hex filename
>    4674       0     160    4834    12e2 passwd.o
> 
> Current svn version is attached.
> --
> vda
> 

Hi Denis,
you can use this patch as it applies just with some fuzz
to current svn:

root at box:~/Desktop/busybox/loginutils# patch -p1 -E <passwd.patch
patching file passwd.c
Hunk #1 succeeded at 52 (offset 8 lines).
Hunk #2 succeeded at 61 (offset 8 lines).
Hunk #3 succeeded at 75 (offset 8 lines).
Hunk #4 succeeded at 111 (offset 6 lines).
Hunk #5 succeeded at 138 (offset 6 lines).
Hunk #6 succeeded at 226 (offset 6 lines).
Hunk #7 succeeded at 247 (offset 6 lines).
Hunk #8 succeeded at 267 (offset 6 lines).
Hunk #9 succeeded at 325 (offset 6 lines).

I inspected the patched file and compile tested it and everything seems to be ok.

Ciao,
Tito
-------------- next part --------------
A non-text attachment was scrubbed...
Name: passwd.patch
Type: text/x-diff
Size: 5555 bytes
Desc: not available
Url : http://busybox.net/lists/busybox/attachments/20061201/16549447/attachment-0001.bin