busybox current status

[Rob Landley]

On Saturday 02 December 2006 5:05 pm, Denis Vlasenko wrote:
> I sent you new sed.c which has that fixed.

I'm not going to test that statement. :)

> Roberto, I was looking into your patch busybox-20061130_sed.patch.
> I have some problems with it.
> 
> Try to limit usage of static data.
> 
> Try to make code easier to understand. sed code is convoluted enough
> already, have heart for poor souls (probably you, a year from now)
> which will come later and will try to figure out how it works.

When I started with busybox, the first thing I did was upgrade the sed that 
was there to make it actually _work_ with the ./configure stages of binutils 
and gcc.  (This took something like a month.)

I never actually went back and redid the structure I'd inherited (my goal was 
minimally intrustive changes), but for toybox I'm writing a new one.

> It's best to try to make it so that C code itself is easy to read,
> but if you have clever but obscure trick, document how it works
> in comments.

One of my early patches to the thing added an overview, because I wanted to 
document what had been hard for me to understand by reading the thing:
http://busybox.net/cgi-bin/viewcvs.cgi/trunk/busybox/editors/sed.c?rev=7583&r1=7560&r2=7583

Rob
-- 
"Perfection is reached, not when there is no longer anything to add, but
when there is no longer anything to take away." - Antoine de Saint-Exupery