busybox current status

[Roberto A. Foglietta]

2006/12/2, Denis Vlasenko <vda.linux at googlemail.com>:

> Roberto, I was looking into your patch busybox-20061130_sed.patch.
> I have some problems with it.
>
> Try to limit usage of static data.
>

 ok, prisubst could be passed as an argument pointer as no_newline.
 I just used static thinking: I will found a solution and after I will
make it more beauty after

> Try to make code easier to understand. sed code is convoluted enough
> already, have heart for poor souls (probably you, a year from now)
> which will come later and will try to figure out how it works.

 ok, you are right but sed is difficult itself I did not added much
more complexity.

> About that particular patch: "static char prisubst" variable name
> is not descriptive. Is it used to skip subst commands (if I read
> the code right)? Why it is called prisubst and not skip_next_subst?

 yes you are right... the name was PRIor SUBSTitution, not so bad
thinking I would have changed it after I made it works in something
like no_newline

 4th: I have not left for tomorow what I would have been done for today!
 ;-)

 Cheers,
-- 
/roberto