[PATCH] add a new unlzma applet
Roberto A. Foglietta
me at roberto.foglietta.name
Wed Jan 18 00:57:39 PST 2006
Rob Landley ha scritto:
>
>>>Does rc_read_byte() really need to be a function? It's used in exactly
>>>two places and expands to a very small amount of straightforward code
>>>that's inlined anyway. (A similar comment could be made about rc_test.)
>>
>>True. In fact that was a kind of raw implementation of standard rangecoder
>>algorithm. But those functions where quite stupid, so removed.
>>
>>
>>>And
>>>rc_free() there's just no excuse for, it's just a wrapper around free()
>>>that's only called once
>>
>>I somewhat disagree about this. On a purely technical POV, you're right.
>>But at a higher "algorithmic" level, this rc_free() allow a total
>>abstraction of the rangecoder.
>
>
> Meaning what?
>
I think he would say: tomorrow if you want change algorithms the
rc_functions changes inside but their API still the same. Is it right?
Cheers,
--
Roberto A. Foglietta
http://www.roberto.foglietta.name
SkypeNick: robang74
ICQ#: 108718257
More information about the busybox
mailing list