[PATCH] Re: Sigh... Bumping the sed nul fix to 1.1.2.

Roberto A. Foglietta me at roberto.foglietta.name
Sat Mar 4 15:07:44 UTC 2006


  Ok Rob, I think this thread is going on too much...
  It time to close it, don't you agree with this?
  So I worked all the day on this problem...


patch -p0 <busybox.14360_sed7_testsuite.patch
make allnoconfig
make menuconfig editors/sed -->YES
cd busybox/testsuite

[roberto at nbraf testsuite]$ ./sed.tests | grep FAIL | tail -n1
FAIL: sed zero support

[roberto at nbraf testsuite]$ ./sed.tests | grep FAIL | wc -l
7   <--- same 6 + 1 (my test s/ciao/miao/ on 000ciao\n000)

cd ../..
patch -p0 <busybox.14360_sed7.patch
cd busybox/testsuite
make -C ..

[roberto at nbraf testsuite]$ ./sed.tests | grep FAIL
FAIL: sed s//g (exhaustive)
FAIL: sed n (flushes pattern space, terminates early)
FAIL: sed N (doesn't flush pattern space when terminating)
FAIL: sed embedded NUL
FAIL: sed append autoinserts newline
FAIL: sed clusternewline

[roberto at nbraf testsuite]$ ./sed.tests | grep FAIL | wc -l
6


About FAIL: sed s//g (exhaustive) I have gone a step further:

old expected is           \nbang\nbang

new expected is           0bang0bang0

correct one would be      0bang0woo0

Now, sed supports zeros but it consider it as \n in substitutions



  Cheers,
-- 
Roberto A. Foglietta
http://roberto.foglietta.name
http://linux.genova.it
skype: robang74
-------------- next part --------------
A non-text attachment was scrubbed...
Name: busybox.14360_sed7.patch
Type: text/x-patch
Size: 1596 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20060304/965ca430/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: busybox.14360_sed7_testsuite.patch
Type: text/x-patch
Size: 961 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20060304/965ca430/attachment-0001.bin 


More information about the busybox mailing list