[PATCH] Remove extraneous cruft from end of libbb/Makefile.in
Rob Landley
rob at landley.net
Tue Mar 28 19:50:13 UTC 2006
On Tuesday 28 March 2006 5:32 am, Robert P. J. Day wrote:
> > I fail to see the benefit of your previous patch to add vpath.
> > Doesn't this just make the build (slightly) slower since you removed
> > the explicit path to the source? It sounds like with your proposed
> > patch, make would have to iterate over a list (of several vpath's)
> > instead of the explicit path..
>
> whether or not it makes the build slightly slower is, IMHO, not
> relevant. it's a question of clean(er) design. i've never been a fan
> of hard-coding ${SRCDIR} into every instance of a source file
> dependency -- that's precisely the thing "vpath" is designed to avoid.
And having said that I'd stay out...
Try benchmarking to see if the difference is actually noticeable.
Rob
--
Never bet against the cheap plastic solution.
More information about the busybox
mailing list