What about breaking trunk? [was: Re: Review of the last few applied patches...]

[Bernhard Fischer]

On Fri, May 19, 2006 at 01:28:05PM -0400, Rob Landley wrote:
>Review of yesterday's committed patches...

[]
>15133:
>Since /dev/null isn't going to move, this is just a size optimization, and
>my question is does building all sources at once get this for us?  If so,
>we don't need the complexity, and should probably remove bb_dev_null.  (It'll
>be 2-3 years before building all sources at once becomes the recommended way
>to do it, but we should start thinking about it now and avoid some cleanups
>we'd just have to revert.)
>
>We should check and make sure that building all sources at once _does_ merge
>duplicate strings.  Let's see...  make clean, make defconfig, switch on
>build at once, then "strings busybox | sort | uniq -d"...
>
>Oh dear.  Somebody needs to poke the gcc guys.  We've got _lots_ of
>duplicate strings that aren't being merged.  Apparently, we've even got
>two copies of the CONFIG ones (for example, CONFIG_ADDGROUP is on line 5474
>and line 7608 of the "strings busybox" output for the build at once version
>configured with defconfig).  Why do we have two copies of the CONFIG strings
>in the busybox binary?
>
>I just hand edited the duplicate strings output to remove the false positives,
>and there's 615 left.  (See attachment.)

[]

>until you decide to write them. After that, of course, the previous

This is disgusting.

I'm tempted to add a CONFIG_DEBUG_KEEP_NLS_CRAP which undefines _ (see
platform.h, NLS cruft)
and force anyone into a quick but stringently needed cleanup of this
mess before we freeze for 1.2.


Index: include/platform.h
===================================================================
--- include/platform.h	(revision 15140)
+++ include/platform.h	(working copy)
@@ -99,9 +99,11 @@
 #endif
 
 /* ---- miscellaneous --------------------------------------- */
+#if ENABLE_DEBUG_KEEP_NLS_CRAP
 /* NLS stuff */
 /* THIS SHOULD BE CLEANED OUT OF THE TREE ENTIRELY */
 #define _(Text) Text
 #define N_(Text) (Text)
+#endif
 
 #endif	/* platform.h	*/


>usleep
>/usr/bin
>/usr/sbin
>vfork
>waitpid
>while
>Zonesize=%d