[PATCH] hdparm size reduction

Tito farmatito at tiscali.it
Wed May 3 06:46:06 UTC 2006


On Wednesday 3 May 2006 00:50, Rob Landley wrote:
> On Tuesday 02 May 2006 3:29 pm, Tito wrote:
> > On Tuesday 2 May 2006 15:43, Rob Landley wrote:
> > > On Tuesday 02 May 2006 2:07 am, Tito wrote:
> > > > On Monday 1 May 2006 21:19, you wrote:
> > > > > On Saturday 29 April 2006 3:14 pm, Tito wrote:
> >
> > snip
> >
> > > > BTW: identify() could be a candidate for an ATTRIBUTE_NORETURN?
> > >
> > > Could be.  Want to send a new patch with a respin of the rejected hunks
> > > plus this?
> >
> > Here it is: hdparm07.patch!!!
> 
> My if (BB_BIG_ENDIAN) hunk was there to avoid the memcpy when we didn't need 
> to do it.  (Hopefully the compiler is smart enough to realize that val can 
> optimized away when it's just an alias for another variable.)
> 
> You removed that.  Was there a reason?

Just copy and paste from hdparm 6.6+

Tito

 > Rob 



More information about the busybox mailing list