kbuild transition misc issues

[Denis Vlasenko]

On Thursday 02 November 2006 18:06, Bernhard Fischer wrote:
> Hi,
> 
> Random notes that beg for patches/ideas/comments from any interrested
> party..
> 
> 1) duplicate Config.in entry
> 
> $ make oldconfig > /dev/null
> .config:525:warning: trying to reassign symbol FEATURE_IFUPDOWN_IP_BUILTIN
> .config:637:warning: symbol value '' invalid for FEATURE_COMMAND_HISTORY
> 
> And indeed, there is something wrong there:
> $ grep -A1 FEATURE_IFUPDOWN_IP_BUILTIN networking/Config.in
> config FEATURE_IFUPDOWN_IP_BUILTIN
> 	bool "Use busybox ip applet"
> --
> config FEATURE_IFUPDOWN_IP_BUILTIN
> 	bool "Use busybox ifconfig and route applets"
> 
> Looks like the second one wants another config symbol, no?

Done: renamed to FEATURE_IFUPDOWN_IFCONFIG_BUILTIN

> I suggest that we do:
> 2a)
> Index: shell/Config.in
> ===================================================================
> --- shell/Config.in	(revision 16488)
> +++ shell/Config.in	(working copy)
> @@ -257,6 +257,7 @@
>  
>  config FEATURE_COMMAND_HISTORY
>  	int "History size"
> +	range 0 4294967295
>  	default 15
>  	depends on FEATURE_COMMAND_EDITING
>  	help
>
> to limit it to something vaguely reasonable.
> This doesn't seem to work with our fork of the kbuild stuff, i fear.
> Lingering bug? Due to our defconfig ignoring all of shell/* ?

Done. I suppose "range 0 99999" is big enough.
This hopefully helps with "#defined to ''" problem:
#define MAX_HISTORY   (CONFIG_FEATURE_COMMAND_HISTORY + 0)

> 2b)
> add a check against an upper limit in cmdedit.c
> 2c) xmalloc the static char *history

I'm cowardly trying to avoid looking into shell mess...

> 3) Config.in and improper CONFIG_foo leftovers
> $ find ./ -name Config.in -exec grep -Hirn "[^_F]CONFIG_" {} \;
> ./networking/Config.in:56:	depends on GETOPT_LONG && (CONFIG_FTPGET || FTPPUT)

Done.

> ./networking/Config.in:248:	depends on IFUPDOWN && !CONFIG_FEATURE_IFUPDOWN_IP

Done.

Thank you.
--
vda