svn commit: trunk/busybox: libbb shell

[Bernhard Fischer]

On Wed, Nov 01, 2006 at 06:36:36PM +0100, Denis Vlasenko wrote:
>On Wednesday 01 November 2006 12:49, Bernhard Fischer wrote:
>> On Wed, Nov 01, 2006 at 01:13:27AM -0800, vda at busybox.net wrote:
>> >Author: vda
>> >Date: 2006-11-01 01:13:26 -0800 (Wed, 01 Nov 2006)
>> >New Revision: 16483
>> >
>> >Log:
>> >#if CONFIG_xxx -> #if ENABLE_xxx
>> 
>> Still, you didn't do this for cmdedit.h. Why?
>
>Because cmdedit.h don't have #if CONFIG (it has #ifdef CONFIG).
>
>The difference is that #if CONFIG_xxx is, strictly speaking, a bug,
>because if symbol is not defined, it expands into
>
>#if CONFIG_xxx
>
>not "#if 0" or "#if 1" as was intended!
>This is wrong (and IIRC newer gcc will complain).

Agree. -Wundef