[BusyBox 0000980]: patch to avoid "broadcast +" syntax

[Denis Vlasenko]

On Tuesday 21 November 2006 20:25, Roberto A. Foglietta wrote:
> > Do I understand you correctly that "standard" ifconfig automatically
> > deduces bcast addr while bbox's requires "broadcast +" on the command
> > line.

I do not understand what that patch fixes. Can you provide an
example? I tried to find an example myself, but failed...

> > And BTW, why ifconfig insists on continuing on errors, sometimes even
> > without error message? It's more natural and probably better to bail out
> > with error message on stderr... 
> 
>   Sorry I cannot understand what you have wrote... If you will write to 
> me in plain english I will appreciate very much.
> 
>   The only thing my patch does is to verify if bcast could be 
> automatically found from others parameters.
>   It does not change any error or printing policy.

Yes, I do not blame you on that. I was reading ifconfig.c
and was puzzled why it doesn't use bb_[p]error_msg_and_die()
that much. It tries to continue iterating through main
while() loop even after errors. For example:

        if (in_ether(host, &sa)) {
                bb_error_msg("invalid hw-addr %s", host);
                ++goterr;
                continue;
        }

I can apply attached patch, but maybe there is some valid reason
to leave it as is?
--
vda
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 44.patch
Type: text/x-diff
Size: 8591 bytes
Desc: not available
Url : http://busybox.net/lists/busybox/attachments/20061121/97cd49dc/attachment.bin