[RFC, PATCH] passwd size reduction

Denis Vlasenko vda.linux at googlemail.com
Thu Nov 30 15:24:12 PST 2006


On Thursday 30 November 2006 20:44, Bernhard Fischer wrote:
> >I applied the rest. Also started to look into passwd.c... well...
> >not very pretty.
> 
> it's ugly, yes. Tito rewrote it a while back, but the patch was not
> applied, IIRC. Not sure about the reasoning.
> 
> http://busybox.net/lists/busybox/2006-November/025406.html
> 
> I didn't have a chance to look at Tito's reimpl, but if it's smaller
> than what we have now (including the goto-ification), then by all
> means, apply it. It can't be worse than the current incarnation ;)

Spent today rewriting most of it. Entire backup function is eliminated,
large on-stack and bss buffers are history too.
--
vda


More information about the busybox mailing list