[PATCH] Add subsystem support to mdev (firmware loading)

[Denis Vlasenko]

On Monday 02 October 2006 12:41, Michael-Luke Jones wrote:
> I'm slightly concerned that with the change of maintainers, this  
> patch could be lost.

                        snprintf(temp, PATH_MAX, "/lib/mdev/%s", getenv("SUBSYSTEM"));
                        if (stat(temp, &st) == 0) {
                                if ((st.st_mode & S_IXUSR) && S_ISREG(st.st_mode)) {
                                        system(temp);
                                }
                        }

Why you are doing it like this? Isn't it simpler to do
usual fork+exec instead, without any checks for existence/executability?

Please provide updated patch. (BTW there is unchecked sprintf
immediately before your code. Care to fix it too?
 
> I'm just going to reiterate how vital firmware loading is to a small  
> but growing proportion of embedded Linux users, and hope that you see  
> it as a valid addition to the codebase.
> 
> As well as the patch, a very simple script (also attached below)  
> should be added to the examples directory to handle firmware loading.
--
vda