[BusyBox 0001076]: "ip addr del" does not work

[Denis Vlasenko]

On Thursday 26 October 2006 21:40, Robert P. J. Day wrote:
> > > int compare_string_array(const char * const string_array[], const char *key)
> > > {
> > >  		return compare_string_array_internal(string_array, key, 1);
> > > }
> >
> > compare_string_array({"aaa","bbb","ccc"}, "b") returns 1 -- ??!
> >
> > > int compare_substring_array(const char * const string_array[], const char *key)
> >
> > Name of this one doesn't immediately say what it is doing.
> > I have hard time imagining a "substring array" at all...
> >
> > compare_string_array() is also can have better name.
> > find_in_string_array()?
> 
> there's a recommended rule that functions be given names so that, when
> used in their natural context, they make intuitive sense.  for
> instance,
> 
>   if (compare_string_array(...)) {
> 
> doesn't really suggest what's being returned, but
> 
>   if (string_array_contains_string(...)) {
> 
> should be immediately obvious.  or something like that.

compare_string_array() returns index of string, not just 1/0.
index_in_str_array()?
--
vda