[RFC] make bb_[p]error_msgXXXX() functions able to direct output to syslog
Denis Vlasenko
vda.linux at googlemail.com
Mon Sep 4 08:56:34 PDT 2006
On Sunday 03 September 2006 21:14, Tito wrote:
> So, then go for it!
> Maybe you can use this snippet of code for inspiration,
> so at least my work wasn't a total waste of time.
>
> int bb_facility = LOG_USER;
>
>
> {
> va_list p;
> va_list p2;
>
> va_start(p, fmt);
> va_copy(p2, p);
> /* bb_err_msg stuff here */
> openlog(bb_applet_name, LOG_PID | LOG_CONS | LOG_NOWAIT, bb_facility);
> vsyslog(LOG_ERR, fmt, p2);
> if (ENABLE_FEATURE_CLEAN_UP) closelog();
> va_end(p);
> va_end(p2);
> }
>
> Ciao,
> Tito
Working on it. Did not manage to make it ready for review today,
hopefully tomorrow.
Bloatcheck looks like this after few applets were converted
to new method of talking to syslog:
function old new delta
bb_verror_msg 76 334 +258
bb_vinfo_msg - 83 +83
xxstrdup - 41 +41
bb_info_msg - 31 +31
nameif_main 957 973 +16
telnetd_main 1802 1811 +9
bb_logmode - 4 +4
fakeidentd_main 1061 1064 +3
reapchild 290 292 +2
xasprintf 60 61 +1
unregister_rpc 83 84 +1
flags 55 51 -4
config 2495 2491 -4
setup 722 716 -6
bump_nofile 344 338 -6
getconfigent 2116 2109 -7
inetd_main 3341 3329 -12
bb_error_msg_and_die 62 45 -17
bb_error_msg 50 33 -17
godaemon 273 252 -21
bb_vherror_msg 84 50 -34
new_servtab 65 24 -41
setup_environment 396 353 -43
zcip_main 2576 2530 -46
bb_vperror_msg 100 50 -50
make_new_session 592 541 -51
arp 358 301 -57
newstr 89 - -89
serror 120 - -120
dupconfig 498 315 -183
run 2191 1998 -193
.rodata 258092 257828 -264
------------------------------------------------------------------------------
(add/remove: 4/2 grow/shrink: 7/19 up/down: 449/-1265) Total: -816 bytes
--
vda
More information about the busybox
mailing list