[PATCH/RFC] teach bb_xx_msg to optionally send msgs to syslog

Rob Landley rob at landley.net
Tue Sep 5 10:01:26 PDT 2006


On Tuesday 05 September 2006 2:18 am, Denis Vlasenko wrote:
> Too large to post here (~80k). Fetch them at
> http://busybox.net/~vda/syslog/
> 
> In short, this implements optional syslog logging
> using ordinary bb_xx_msg calls, and converts networking/*
> to it. The rest of bbox will be converted gradually
> after inclusion to mainline.
> 
> 1.patch
> 	extern int bb_logmode, LOGMODE_STDIO/SYSLOG/BOTH.
> 	Teach bb_verror_msg() to optionally log to syslog
> 	Add bb_[v]info_msg. (Not final code, will be
> 	improved - see later patches)

I mentioned earlier that I'm trying to get away from bb_ prefixes.  Could you 
please pick a name that hasn't got one?

Also, please use your own name in the copyright message when you add new 
files.  (Yeah, there's a reason for this.  Although the Berne convention 
gives a certain amount of uniformity to copyright law internationally, 
actually assigning one of your copyrights to Erik involves a "written 
instrument of conveyance" under US law, and is more or less impossible under 
German law, and I really don't want to go there under any jurisdiction.  As 
long as all the copyrights are licensed the same, we're good.)

libbb.h should already #include most of the other standard headers you need.  
(This avoids endless patches where the Cray 1 needs 
#include "<fruitbasket.h>" after every occurrence of stdio.h, and this occurs 
in 15 files...)

On the whole, it looks good.

Rob
-- 
Never bet against the cheap plastic solution.


More information about the busybox mailing list