svn 16130

Rob Landley rob at landley.net
Mon Sep 18 06:24:48 PDT 2006


Why this bit?

        if (opt_host) {
-               if (ENABLE_FEATURE_UTMP)
+               USE_FEATURE_UTMP(
                        safe_strncpy(utent.ut_host, opt_host, 
sizeof(utent.ut_host));
+               )

The if(ENABLE) clause should never cause a config-dependent build break.  The 
USE() clause can.  It doesn't seem like it will in this instance, but in 
general it's good to use ENABLE where possible, instead of USE().  Why the 
switch from one to the other here?

Rob
-- 
Never bet against the cheap plastic solution.


More information about the busybox mailing list