Why is svn 14061 a good idea?

[Yann E. MORIN]

On Tuesday 05 September 2006 054, Rob Landley wrote:
> Ok, so this checkin replaces this:
> > -               if (fnmatch(list->data, filename, FNM_LEADING_DIR) == 0) {
> > -                       return (list);
> (Question #1: does uClibc support it?)

Yes, it does at least since 0.9.28 (and maybe before as well):
include/fnmatch.h at 58:
#if !defined _POSIX_C_SOURCE || _POSIX_C_SOURCE < 2 || defined _GNU_SOURCE
# define FNM_FILE_NAME   FNM_PATHNAME   /* Preferred GNU name.  */
# define FNM_LEADING_DIR (1 << 3)   /* Ignore `/...' after a match.  */
# define FNM_CASEFOLD    (1 << 4)   /* Compare without regard to case.  */
# define FNM_EXTMATCH    (1 << 5)   /* Use ksh-like extended matching. */
#endif

In a real world, we're using glibc or uClibc. Both support those extensions.

For what it's worth, I'd say: use that and revert 16041.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +0/33 662376056 | Software  Designer | \ / CAMPAIGN     |   ^                |
| --==< °_° >==-- °---.----------------:  X  AGAINST      |  /e\  There is no  |
| web: ymorin.free.fr | SETI at home 3808 | / \ HTML MAIL    |  """  conspiracy.  |
°---------------------°----------------°------------------°--------------------°