svn commit: trunk/busybox: archival libbb

[Denis Vlasenko]

On Sunday 10 September 2006 19:39, Rob Landley wrote:
> On Sunday 10 September 2006 8:02 am, Tito wrote:
> > "bb_[p]error prints "<appletname>: <message>\n". Starting <message>
> > with capital letter is not correct wrt English language.
> > I am nitpicking here..."
> >
> >  bb_info_msg("Something");
> 
> You are aware that several of our error messages are "ioctl" or similar?  
> Because this error message is very small?
> 
> You are also aware that these are english strings hardwired into the code, not 
> internationalized?
> 
> Personally, I prefer the capitalized versions.  I also think this is an 
> example of pointless churn that accomplishes nothing and I politely ask that 
> it please stop.  If you're making the error message clearer, or smaller, 
> fine.  Quit fiddling with the capitalization.

However I find it not nice that we sometimes say

readprofile: error writing <something>

and sometimes

readprofile: Assuming reversed byte order.

This is already not consistent.

./util-linux/readprofile.c:                     bb_perror_msg_and_die("error writing %s", defaultpro);
./util-linux/readprofile.c:                     bb_error_msg("Assuming reversed byte order. "
./util-linux/readprofile.c:                     bb_error_msg_and_die("%s(%i): wrong map line",
./util-linux/readprofile.c:             bb_error_msg_and_die("can't find \"_stext\" in %s", mapFile);
./util-linux/readprofile.c:                     bb_error_msg_and_die("%s(%i): wrong map line",
./util-linux/readprofile.c:                     bb_error_msg_and_die("profile address out of range. "

If we want consistency, then obvoiusly non-capitalized
version is more correct wrt English language.

Again, I am not trying to enforce correct English per se.
I am not embarking on a crusade to add/remove "a", "the" etc...

We simply have two choices here: (1) capitalize (2) don't capitalize
and they are equal on all measures (same code size, etc)
except that (2) is more correct wrt natural languare rules,
so why not pick (2)?

Of course there is choice (3) let it be forever inconsistent,
but why?
 
> > This sure is correct, but in my opinion is not worth the effort...
> > and to be the biggest of "nitpickers" i would suggest to add a dot "."
> > at the end of every sentence increasing the size of bb a few  Kb.
> 
> No.

"No" seconded. When size matters, I pick smaller.
For example, "couldn't" can usually be replaced by "can't"...

I think the good decision would be:

1) error_msg() message text should not be capitalized,
   but existing code should not be massively fixed, can be
   done gradually while fixing/rewriting nearby code.

2) Period at the end of one-sentence messages should be avoided
   for size reasons. (Multi-sentence messages may have
   trailing period)

Is it okay with you Rob?
--
vda