[RFC, PATCH] new applet resize #2
Bernhard Fischer
rep.nop at aon.at
Fri Sep 22 08:25:10 UTC 2006
On Thu, Sep 21, 2006 at 11:25:04PM -0400, Rob Landley wrote:
>On Thursday 21 September 2006 5:45 pm, Bernhard Fischer wrote:
>> It's ment as a suggestion to emit the string conditionally in case
>> somebody wants to preserve the behaviour of the bloated normal binary
>> that is not in busybox.
>
>The normal binary? (Rummage...) Ah, so there is. Part of X from _1984_.
>Wow.
>
>Ok, preserving the behavior of that strikes me as a good thing. I guess that
I've applied it as r16176 for now.
Feel free to wipe it out of the tree like you did with taskset, if you
feel like.
>means I should take another look at the patch...
>
>+#define RESIZE_TIOS_TIMEOUT 100 /* in deciseconds */
>+#if defined(RESIZE_TIOS_TIMEOUT) && (RESIZE_TIOS_TIMEOUT > 0)
>
>What on _earth_?
The version i checked in doesn't set a timeout. It can easily be fixed
later on, if needed (i wouldn't be surprised if a timeout handling is
needed in the wild).
>
>+int resize_main(int ATTRIBUTE_UNUSED argc, char ATTRIBUTE_UNUSED **argv) {
>
>The curly bracket goes on the start of the next line.
done.
>I am already not getting warnings about unused parameters. Why are you
>getting them?
because i asked to get them since they remind me that it's a todo (for
me, at least) ;)
cheers,
Bernhard
More information about the busybox
mailing list