svn commit: trunk/busybox/coreutils

[Bernhard Fischer]

On Thu, Apr 05, 2007 at 02:44:42AM +0200, Denis Vlasenko wrote:
>On Wednesday 04 April 2007 16:01, aldot at busybox.net wrote:
>> +#define OP_bs		0 + 1
>> +#define OP_count	OP_bs + 1
>> +#define OP_seek		OP_count + 1
>> +#define OP_skip		OP_seek + 1
>> +#define OP_if		OP_skip + 1
>> +#define OP_of		OP_if + 1
>> +#define OP_ibs		OP_of + ENABLE_FEATURE_DD_IBS_OBS
>> +#define OP_obs		OP_ibs + ENABLE_FEATURE_DD_IBS_OBS
>> +#define OP_conv		OP_obs + ENABLE_FEATURE_DD_IBS_OBS
>> +#define OP_conv_notrunc	OP_conv + ENABLE_FEATURE_DD_IBS_OBS
>> +#define OP_conv_sync	OP_conv_notrunc + ENABLE_FEATURE_DD_IBS_OBS
>> +#define OP_conv_noerror	OP_conv_sync + ENABLE_FEATURE_DD_IBS_OBS
>
>You do not use (), this is dangerous.

ouch, forgot those, yes.
>
>This can be done better with enum. Example from find:

Yes, that's better. I'll keep this in mind in the future.
Thanks for the heads-up.