[PATCH - RESEND] addgroup code cleanup, size reduction and feature enhancement

Bernhard Fischer rep.dot.nop at gmail.com
Thu Apr 5 06:12:43 PDT 2007


On Thu, Apr 05, 2007 at 01:44:58PM +0200, Tito wrote:
>On Thursday 05 April 2007 10:43:10 you wrote:
>> On Thu, 2007-04-05 at 08:33 +0200, Tito wrote:
>> 
>> > 2) crippled function removal:
>> > the current addgroup applet when called with 2 arguments
>> > permits only to add an existing user to an still to be created group.
>> > This seems to me a crippled behavior as it could be used just one time
>> > at group creation time: 
>> > 
>> > root at localhost:~/Desktop/busybox.new# ./busybox_old addgroup prova tito
>> > root at localhost:~/Desktop/busybox.new# ./busybox_old addgroup prova dina
>> > addgroup: prova: group already in use
>> > 
>> > 3) the above mentioned feature was re-added as optional
>> >     function enabled by ENABLE_FEATURE_ADDUSER_TO_GROUP.
>> >     Now    if  called  with two non-option arguments, addgroup will add an existing
>> >     user to an existing group like the full blown addgroup does (at least on my system).
>> 
>> What system do you use? None of mine systems (Gentoo, Ubuntu, Debian,
>> FreeBSD, OpenBSD) have an addgroup (or groupadd) that allows me to add a
>> user to an existing group.
>
>(k)Ubuntu 6.10
>
>ls -la /usr/sbin/addgroup lrwxrwxrwx 1 root root 7 2007-03-06 15:13 /usr/sbin/addgroup -> adduser
>
>Ciao,
>Tito
>> Anyway... the patch is better than what we have today so it would be
>> nice to see it committed.

Merged. Thanks, Tito!


More information about the busybox mailing list