[patch] netstat: got bogus unix line...

[Cristian Ionescu-Idbohrn]

On Wed, 26 Dec 2007, Denys Vlasenko wrote:

> On Tuesday 25 December 2007 16:34, Cristian Ionescu-Idbohrn wrote:
> >
> > Yes.  But it's too big.  Let's see if attached few lines of
> > /proc/net/unix will suffice.
>
> This line is especially ugly:
>
> f7ab6280: 00000002 00000000 00000000 0002 01 14954 @^@^@^@.^R^@^@x*

Yes, it is.

> I think you have to retest it with latest kernel and if it happens there
> too, report the bug to kernel mailing list.

This may arguably be a kernel problem.  As the comment in the bb-netstat
says, and which I quoted in my previous post, socket names as this one did
show up in 2.6 /proc files for as long as I remember.  IMO, this is more
like an application bug.

> This is what returned by fgets_malloc (in <> braces):
>
> netstat: <f425d100: 00000002 00000000 00010000 0001 01 14216 private/scalemail-backend
> >
> netstat: <f421d980: 00000002 00000000 00010000 0001 01 14220 private/mailman
> >
> netstat: <f7ab6280: 00000002 00000000 00000000 0002 01 14954 @>
> netstat: <>
> netstat: <>
> netstat: <.^R>
> netstat: got bogus unix line '.^R'
>
> It will be not trivial to fix.

No, and I don't think attempting to fix that should be necessary either.

As log as _no attempt_ to display the bogus lines is made all should be
good.  None of the other 3 warnings make any attempts to display the bogus
lines.  'bogus unix line' _should not_ do that either.  This is the "fix"
I'd like to see in bb.


Cheers,

-- 
Cristian