build system doesnt properly detect applet rebuild requirement

Bernhard Fischer rep.dot.nop at gmail.com
Sat Feb 3 04:43:59 PST 2007


On Sat, Feb 03, 2007 at 01:39:51PM +0100, Denis Vlasenko wrote:
>On Saturday 03 February 2007 13:09, Bernhard Fischer wrote:
>> On Sat, Feb 03, 2007 at 02:44:07AM -0500, Mike Frysinger wrote:
>> >$ make distclean
>> >$ make allnoconfig
>> >$ make menuconfig
>> >-> enable dmesg, syslog, klogd, logger
>> >$ make
>> >$ nano .config
>> >-> disable syslog, klogd, logger
>> >$ make oldconfig
>> >$ make
>> ><link failure due to applets.o still wanting syslog/klogd/logger _main funcs>
>> >-mike
>> 
>> Confirmed. See also vda's note that it's disfunctional:
>> http://busybox.net/lists/busybox/2007-January/025966.html
>> 
>> In the old buildsys we had a dependency like
>> applets.o: .config
>> 
>> Nowadays applets.o depends on usage_compressed.h alone.
>> Iff the problem turns out to be passing -include autoconf.h directly
>> (so, perhaps, autoconf.h isn't listed in foo.d as dep), then putting an
>> #include "autoconf.h" into libbb.h would perhaps change that
>> misbehaviour. Any takers?
>
>Attached patch should fix it. Works for me.
>Can someone else confirm?
>
>Will need big dumb patch with lots of
>
>+int ar_main(int argc, char **argv);
> int ar_main(int argc, char **argv)
>
>in order to suppress warnings.

I don't like that approach, personally.
Seen my counter-proposal that i sent a minute ago?


More information about the busybox mailing list