PATCH: replacing exec*p with BB_EXEC*P
Bernhard Fischer
rep.dot.nop at gmail.com
Mon Feb 5 00:49:00 PST 2007
On Mon, Feb 05, 2007 at 07:20:54AM +0100, Tito wrote:
>On Monday 05 February 2007 00:23, Gabriel L. Somlo wrote:
>> + BB_EXECVP(*argv, argv);
>> bb_perror_msg_and_die("cannot execute %s", *argv);
>
>Hi,
>shouldn't the bb_perror_msg_and_die("cannot execute %s", *argv)
>be moved inside BB_EXECVP(*argv, argv); ?
>This would probably save some space.
seconded :)
Also, i'd add a bb_msg_exec_failed
and fixup svngrep -ri "exec.*%s" * to use that msg instead of growing
a dozend of separate messages for this very same error, but maybe that's
just me :P
More information about the busybox
mailing list