stty has warnings -> build failure

Denis Vlasenko vda.linux at googlemail.com
Mon Jan 1 07:20:34 PST 2007


On Monday 01 January 2007 10:28, Mike Frysinger wrote:
> the stty mode_info struct uses a short for the mask ... on my ppc32 system 
> though, some of the masks actually overflow this value and i get warnings
> 
> in particular, the VTDLY stuff expands as:
> VT1 00200000
> 
> and that number won't fit in a short on a 32bit machine
> -mike

Fair enough. I think I will change it like this:

struct mode_info {
        const char *name;       /* Name given on command line           */
        char type;              /* Which structure element to change    */
        char flags;             /* Setting and display options          */
        tcflag_t mask;          /* Other bits to turn off for this mode */
        tcflag_t bits;          /* Bits to set for this mode            */
};

(i.e. last two fields are changed to tcflag_t).
 
Does it work for you?
--
vda


More information about the busybox mailing list