RFC: bbox 1.5.0?

[Natanael Copa]

On Mon, 2007-03-19 at 15:45 +0100, Bernhard Fischer wrote:
> On Mon, Mar 19, 2007 at 03:10:52PM +0100, Natanael Copa wrote:
> >On Sun, 2007-03-18 at 22:17 +0100, Denis Vlasenko wrote:
> >> Hi,
> >> 
> >> I tried to look at less visible places where busybox
> >> in not as small as it could be, and removed a few big
> >> bss buffers. 
> >
> >...
> >
> >> Because of this, and since we started to get more mails
> >> about bugs in 1.4.x which are already fixed in svn, I am
> >> thinking about releasing busybox 1.5.0 before starting
> >> any new significant work on busybox.
> >
> >What plans do you have for post 1.5?
> >
> >> What do you think about this?
> >
> >I think it sounds good. You could declare a feature freeze for a while
> >and start hunting bugs, create a stable branch in svn for 1.5 and
> >release a beta for ppl who dont like building from svn.
> 
> I vote for sed -i -e s/gnu99/c99/ Makefile.flags
> for a couple of days and fix those for a start.. :-/

Shouldn't be too hard. Just some brute force work.

First hit:
include/libbb.h:299: warning: declaration does not declare anything

Code:
typedef struct len_and_sockaddr {
        socklen_t len;
        union {
                struct sockaddr sa;
                struct sockaddr_in sin;
#if ENABLE_FEATURE_IPV6
                struct sockaddr_in6 sin6;
#endif
        };
} len_and_sockaddr;

The problem is that c99 don't allow anonymous unions. Could be fixed
with:

--- include/libbb.h     (revision 18165)
+++ include/libbb.h     (working copy)
@@ -296,7 +296,7 @@
 #if ENABLE_FEATURE_IPV6
                struct sockaddr_in6 sin6;
 #endif
-       };
+       } u;
 } len_and_sockaddr;
 /* Create stream socket, and allocated suitable lsa
  * (lsa of correct size and lsa->sa.sa_family (AF_INET/AF_INET6)) */

but then we need to 's/->sa\./->u.sa./g; s/->sin\./->u.sin./g' lots of
places. Do we want that?

How should we handle anonymous unions properly?

Natanael Copa