trunk compilation broken

[Denis Vlasenko]

Hi Bernhard

On Wednesday 21 March 2007 20:29, Bernhard Fischer wrote:
> the vi fiddling seems to have broken something (for me):
> 
> $ svn info | grep Rev
> Revision: 18191
> Last Changed Rev: 18191
> 
> editors/vi.c: In function 'colon':
> editors/vi.c:843: warning: comparison is always false due to limited
> range of data type

It complains about c > 127:
        c_is_no_print = c > 127 && !Isprint(c);

c is of type char. How did it end up signed for you?

CFLAGS += $(call cc-option,-funsigned-char -static-libgcc,)

But before fixing that, please try whether attached patch
makes vi.c compile w/o warning with signed char.
--
vda
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1.patch
Type: text/x-diff
Size: 4299 bytes
Desc: not available
Url : http://busybox.net/lists/busybox/attachments/20070321/c95eaabd/attachment.bin