Question about insmod/busybox

[Yann E. MORIN]

Hello Khem!

Would have been great if you had CCed the busybox mailing list. :-|

So first thing you have to know: I don't know much of the insmod code. I
maintain the modprobe code when bugs arise, but insmod (at least for 2.4)
is too complex for me (plus I don't use 2.4 any more, and 2.6 is clean).

On Thursday 01 November 2007 20:18:17 Khem Raj wrote:
> I have a question for you about busybox/insmod. I am modifying this so
> that it can load more than one module in one invocation.
> In such a scenario I get a kernel crash after a while when I try to
> insmod 50 modules.

> If I write a shell script which calls insmod 50 times to insert modules
> one by one it works.

That is exactly what I would have suggested: create a script that loops
and calls insmod for each module.

> The modification I do to the insmod is a wrapper which calls
> insmod_ng_main () in a while loop and does the argv processing.

I would say: don't do that, unless the real insmod understands more than
one module as arguments, which I highly doubt.

We try to maintain a compatible API between "original" applications and
the corresponding applets in busybox.

> In this scenario a kernel oops is triggered.
> Now I want to know if insmod is written assuming that only 1 module is
> installed in that case it will not free the malloc'ed memory and this is
>  being caused by memory leak or if there is real problem in kernel.

Could well be that you did not activate CONFIG_FEATURE_CLEAN_UP or/ insmod
does not cleanly handle memory. I guess Denys would be able to tell if insmod
is NOFORK-clean. Denys?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +0/33 662376056 | Software  Designer | \ / CAMPAIGN     |   ^                |
| --==< °_° >==-- °------------.-------:  X  AGAINST      |  /e\  There is no  |
| http://ymorin.is-a-geek.org/ | (*_*) | / \ HTML MAIL    |  """  conspiracy.  |
°------------------------------°-------°------------------°--------------------°