[PATCH] who.c minor size reduction

[Denys Vlasenko]

On Tuesday 13 November 2007 13:55, Tito wrote:
> > > BTW: a silly question, why we don't remove the check for USER_PROCESS 
> > > in this line:
> > >
> > >           if (ut->ut_user[0] && ut->ut_type == USER_PROCESS)
> > >
> > >          so that we get the output of who -a for free and reduce
> > >          size at the same time. Currently there is no way
> > >          to do this. Output would be:
> > >
> > > ./busybox who
> > > USER       TTY      IDLE      TIME            HOST
> > > reboot     ~        ?         Nov 11 10:06:20
> > > runlevel   ~        ?         Nov 11 10:06:20
> > > LOGIN      tty1     03:17     Nov 11 10:06:47
> > > tito       tty2     00:01     Nov 11 13:22:31
> > > LOGIN      tty3     03:17     Nov 11 10:06:47
> > > LOGIN      tty4     03:17     Nov 11 10:06:47
> > > LOGIN      tty5     03:17     Nov 11 10:06:47
> > > LOGIN      tty6     03:17     Nov 11 10:06:47
> >
> > Good idea, just do it conditionally, if -a is passed to who.
>
> Yes, but that way the size increase will be bigger as
> we need:
>
> a call to getopt32
> an opt variable

yes.

> an usage text for -a

usage text is small issue, since it can be globally selected out.

> removing the check seems to be cheaper,

But then users will whine that 'our' who is different from 'standard' -
see similar post about free. Sacrifice 20 bytes and forestall that.
--
vda