Remove common patterns

walter harms wharms at bfs.de
Sat Oct 6 02:37:41 PDT 2007



Denys Vlasenko wrote:
> On Sunday 30 September 2007 15:28, Loïc Grenié wrote:
>>      I've tried to remove "common patterns" in the code.
>>   First try: s/printf("%s", /puts(/ and s/fprintf(fp, "%s",
>> \(.*\))/fputs(\1, fp)/
>>   Patch attached.
> 
> -               printf("%s", error_message(ctx->errcode));
> +               puts(error_message(ctx->errcode));
> 
> 
> These are not equivalent. puts is adding "\n".
> 
> Apart from this - applied, thanks.
> --

I am sorry but is the printf -> puts replacement not done
automagicly by gcc ?

(http://www.ciselant.de/projects/gcc_printf/gcc_printf.html)

re,
 wh






More information about the busybox mailing list