[PATCH] ping with timeouts and deadlines.

Denys Vlasenko vda.linux at googlemail.com
Sun Apr 6 17:46:57 PDT 2008


On Friday 04 April 2008 16:24, James Simmons wrote:
> 
> This patch allows use to timeout for outgoing and incoming packets.
> See ping man pages for more details.

expire is in milliseconds here:

                if (nreceived) {
                        expire = 2 * tmax / 1000;
                        if (expire == 0)
                                expire = 1;
                }
                signal(SIGALRM, pingstats);
but alarm() takes seconds:
                alarm(expire);

+       unsigned sum;

Bad name. Sum of what? It is also ambiguous for grepping.

Apart from these issues, it looks ok.
Applied to svn. Thanks.
--
vda


More information about the busybox mailing list