PATCH: brctl show

[Bernhard Fischer]

On Sun, Apr 06, 2008 at 09:19:24AM +0200, Denys Vlasenko wrote:
>On Saturday 05 April 2008 23:10, L. Gabriel Somlo wrote:
>> Hi,
>> 
>> I need to be able to see the list of ports currently configured on a
>> bridge, so I took a shot at implementing 'brctl show'. Might follow up
>> with 'showmacs' later, but for now, let me know what you think, and
>> please apply...
>
>Applied, thanks.
>
>NB: "standard" brctl talks to kernel via /sys, not ioctls.

No, it doesn't.
Either it would work without *any* ioctl or exclusively via sysfs ¹)
I don't see how mixing sysfs and ioctl interfaces makes any sense at
all, please explain?

>brctl ioctls are deprecated - for one, they don't work
>in 32/64 mixed environment, and will never work -
>kernel people decided to let it rust. (I agree with them).

I disagree, see above. No half-hearted mixture, please.

¹)
I'm attaching a 12 minute hack to allow to switch to sysfs competely.
$ echo a mybr0 > /sys/class/bridge/ctrl
$ echo a mybr1 > /sys/class/bridge/ctrl
$ echo d mybr0 > /sys/class/bridge/ctrl
$ echo a lo > /sys/class/bridge/ctrl
$ echo a loo > /sys/class/bridge/ctrl
$ ls -1 /sys/class/net/

you get the idea..
How would i do this with pristine 2.6.25 (which was current at the time
of this writing)?

TIA for clarification and cheers,
Bernhard
-------------- next part --------------
A non-text attachment was scrubbed...
Name: linux-2.6.25-brctrl-sysfs-fixup.00.diff
Type: text/x-diff
Size: 2197 bytes
Desc: not available
Url : http://busybox.net/lists/busybox/attachments/20080430/0aa27601/attachment.diff