New version of tac.c
Natanael Copa
natanael.copa at gmail.com
Thu Jan 10 02:46:17 PST 2008
On Thu, 2008-01-10 at 09:01 +0100, Tito wrote:
> Hi Denis,
> couldn't we change this 0x7f
>
> if (!(i & 0x7f))
> /* Grow on every 128th char */
> line = xrealloc(line, i + 0x7f + sizeof(int) + 1);
>
> into a define
>
> #define WHATEVER 0x7f
>
> so that it could be changed in one place
> and to improve readability for newbies like me. :-)
>
> Just an idea.
see attatched patch
but im not sure if it makes code more readable
>
> Ciao,
> Tito
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bb-tac-grow_size.patch
Type: text/x-patch
Size: 761 bytes
Desc: not available
Url : http://busybox.net/lists/busybox/attachments/20080110/6e17cb45/attachment.bin
More information about the busybox
mailing list